Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittests #444

Merged
10 commits merged into from
Nov 7, 2022
Merged

Fix unittests #444

10 commits merged into from
Nov 7, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 7, 2022

  • Avoid unnecessary copies in file source stage
  • When we do a copy, perform it before emitting
  • Skip benchmarks by default
  • Adds a benchmark pytest marker and associated --run_benchmark flag

fixes #443

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 2 - In Progress labels Nov 7, 2022
@dagardner-nv dagardner-nv requested a review from a team as a code owner November 7, 2022 17:58
@dagardner-nv dagardner-nv requested a review from a team as a code owner November 7, 2022 18:09
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once all tests are passing, we can merge.

tests/benchmarks/test_bench_e2e_pipelines.py Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@dagardner-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit ebc31ff into nv-morpheus:branch-22.11 Nov 7, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Several unittests fail with latest SRF 22.11 build
2 participants